Merged
Conversation
10494bb to
90d2294
Compare
Member
|
Was most of this CI code taken from another Amethyst repo? It looks like it was. Would be curious to see how their CI runs. Also, I feel like there's a way to get CI to run on a fork? I'll try to run this branch on mine and we can see how it does. |
Member
|
I have CI running on my fork, we can check that the changes run there :) |
8d58c9a to
c06b224
Compare
…rate to github actions. I have absolutly no experience, i just copied legions files, thanks colleagues ;) For now only activate some checks as specs doesnt fully follow fmt or clippy https://www.jeffgeerling.com/blog/2020/travis-cis-new-pricing-plan-threw-wrench-my-open-source-works https://twitter.com/james_hilliard/status/1336081776691843072
c06b224 to
8c56d52
Compare
AngelOnFira
approved these changes
Jun 21, 2022
Member
|
@fhaynes looks like I'll need your perms to make some changes to this repo. We'll need to remove the required status on the |
Member
|
Hey,
Let me get to a computer and I will look at this. Probably an hour or two.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Forest Anderson ***@***.***>
Sent: Tuesday, June 21, 2022 1:45:20 PM
To: amethyst/specs ***@***.***>
Cc: fletcher ***@***.***>; Mention ***@***.***>
Subject: Re: [amethyst/specs] xmac94x/GitHub actions (PR #749)
@fhaynes<https://github.com/fhaynes> looks like I'll need your perms to make some changes to this repo. We'll need to remove the required status on the continuous-integration/travis-ci job, and potentially add the requirement to some new jobs after this merges.
—
Reply to this email directly, view it on GitHub<#749 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABBPMFP2HE22DE4VXYVPXMDVQISWBANCNFSM5ZNGDLNQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
@AngelOnFira @xMAC94x I merged this, and sent you an invite to our long-disused gitter. Please drop by if you have a minute, I'd like to know what the goal here is. |
damody
pushed a commit
to damody/specs
that referenced
this pull request
Jul 24, 2023
…rate to github actions. I have absolutly no experience, i just copied legions files, thanks colleagues ;) (amethyst#749) For now only activate some checks as specs doesnt fully follow fmt or clippy https://www.jeffgeerling.com/blog/2020/travis-cis-new-pricing-plan-threw-wrench-my-open-source-works https://twitter.com/james_hilliard/status/1336081776691843072
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure CI change, just get rid of travis and go to actions (i hope this works)