Skip to content

ament_mypy - Add support for type stubs#516

Merged
ahcorde merged 1 commit intoament:rollingfrom
InvincibleRMC:patch-1
Jan 24, 2025
Merged

ament_mypy - Add support for type stubs#516
ahcorde merged 1 commit intoament:rollingfrom
InvincibleRMC:patch-1

Conversation

@InvincibleRMC
Copy link
Copy Markdown
Contributor

While working on typing rclpy noticed an inconsistency between mypy and ament_mypy since ament_mypy currently ignores type stubs.

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC changed the title Add support for type stubs ament_mypy - Add support for type stubs Jan 16, 2025
@sloretz sloretz self-requested a review January 24, 2025 00:34
@sloretz sloretz self-assigned this Jan 24, 2025
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Jan 24, 2025

Pulls: #516
Gist: https://gist.githubusercontent.com/sloretz/86b74adf4782fed8f67081ff2ec686eb/raw/b24b8cd3ca9792e1f47b339faf9733bfc0d6e322/ros2.repos
BUILD args: --packages-above-and-dependencies rmw
TEST args: --packages-above rmw
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15087

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Flova
Copy link
Copy Markdown

Flova commented Feb 6, 2025

Any chance this will be backported to jazzy?

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Feb 10, 2025

@Mergifyio backport jazzy humble

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 10, 2025

backport jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Feb 10, 2025
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 03194e1)
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 03194e1)
sloretz pushed a commit that referenced this pull request Feb 23, 2025
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 03194e1)

Co-authored-by: Michael Carlstrom <rmc@carlstrom.com>
sloretz pushed a commit that referenced this pull request Feb 23, 2025
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 03194e1)

Co-authored-by: Michael Carlstrom <rmc@carlstrom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants