Skip to content

Close source files after reading them#249

Merged
cottsay merged 2 commits intomasterfrom
resource_warning
May 19, 2020
Merged

Close source files after reading them#249
cottsay merged 2 commits intomasterfrom
resource_warning

Conversation

@cottsay
Copy link
Copy Markdown
Contributor

@cottsay cottsay commented May 18, 2020 •
edited
Loading

Resolves the ResourceWarning messages coming to the console during testing with debug-enabled Python. These messages cause a significant amount of noise on the console.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Example warning:

C:\ci\ws\install\Lib\site-packages\ament_lint_cmake\cmakelint.py:408: ResourceWarning: unclosed file <_io.TextIOWrapper name='CMakeLists.txt' mode='r' encoding='cp1252'>
  for l in open(filename).readlines():
ResourceWarning: Enable tracemalloc to get the object allocation traceback

@cottsay
Close source files after reading them
337c6a6 
Resolves the ResourceWarning messages coming to the console during
testing with debug-enabled Python.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added bug Something isn't working in review Waiting for review (Kanban column) labels May 18, 2020
@cottsay cottsay self-assigned this May 18, 2020
jacobperron
jacobperron approved these changes May 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dirk-thomas
dirk-thomas reviewed May 19, 2020
View reviewed changes
@cottsay
Align file name with upstream proposal
341a820 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the resource_warning branch from 623b8f7 to 341a820 Compare May 19, 2020 02:07
@cottsay cottsay merged commit a11ea56 into master May 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the resource_warning branch May 19, 2020 02:23
@jacobperron jacobperron mentioned this pull request Sep 20, 2021
Merged
kenji-miyake pushed a commit to kenji-miyake/ament_lint that referenced this pull request Oct 20, 2021
@cottsay
Close source files after reading them (ament#249)
be32cb7 
Resolves the ResourceWarning messages coming to the console during
testing with debug-enabled Python.

Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

+1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cottsay cottsay

Labels

bug Something isn't working in review Waiting for review (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cottsay @jacobperron @dirk-thomas