Skip to content

Generate xunit files valid for the junit10.xsd#220

Merged
j-rivero merged 1 commit intomasterfrom
junit10_xsd
Mar 11, 2020
Merged

Generate xunit files valid for the junit10.xsd#220
j-rivero merged 1 commit intomasterfrom
junit10_xsd

Conversation

@j-rivero
Copy link
Copy Markdown

@j-rivero j-rivero commented Mar 11, 2020

With the new xunit plugin version 2.x the xunit files generated should be compliant with the junit10.xsd.

The current code in different packages writing xunit files lacks the required attribute errors and use skipped instead of skip. For the skip attribute the change is trivial. For the errors attribute the description is:

The total number of tests in the suite that errored. An errored test is one that had an unanticipated problem. e.g., an unchecked throwable; or a problem with the implementation of the test

The code of linters in this repository exit the test to the system if it founds some problems with the manipulation of the different tools (like the lack of cppcheck in ament_cppcheck) so I'm assuming here that if the test is not aborted before the number of these errors is 0.

Locally the files can be validated using (download the xsd from the link above):
xmllint --schema junit-10.xsd path/to/ppcheck.xunit.xml --noout

Waiting the buildfarm test for this job: Build Status

Generate xunit files valid for the junit10.xsd
269ba56 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from dirk-thomas March 11, 2020 17:21
@dirk-thomas
Copy link
Copy Markdown
Contributor

dirk-thomas commented Mar 11, 2020

I'm assuming here that if the test is not aborted before the number of these errors is 0.

Should this be updated then to signal an errors="1" instead of failures="1" then? https://github.com/ament/ament_cmake/blob/37ed0dcde921f4f0dd29e0e6cf64c55f85e193f0/ament_cmake_test/ament_cmake_test/__init__.py#L307

@j-rivero j-rivero mentioned this pull request Mar 11, 2020
Merged
@j-rivero
Copy link
Copy Markdown
Author

j-rivero commented Mar 11, 2020

I'm assuming here that if the test is not aborted before the number of these errors is 0.

Should this be updated then to signal an errors="1" instead of failures="1" then? https://github.com/ament/ament_cmake/blob/37ed0dcde921f4f0dd29e0e6cf64c55f85e193f0/ament_cmake_test/ament_cmake_test/__init__.py#L307

In the case of detecting segfaults or other problems not related to bad results of the test I think so. Let's follow this here: ament/ament_cmake#225

@j-rivero j-rivero merged commit c7de932 into master Mar 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the junit10_xsd branch March 11, 2020 18:07
@j-rivero j-rivero mentioned this pull request Mar 12, 2020
Merged
nuclearsandwich pushed a commit that referenced this pull request Mar 20, 2020
@nuclearsandwich
Generate xunit files valid for the junit10.xsd (#220)
6d67e23 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
nuclearsandwich pushed a commit that referenced this pull request Mar 20, 2020
@nuclearsandwich
Generate xunit files valid for the junit10.xsd (#220)
88a4350 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
This was referenced Mar 23, 2020
Merged
Merged
nuclearsandwich added a commit that referenced this pull request Mar 26, 2020
@nuclearsandwich @dirk-thomas
[Eloquent] Backport junit xml fixes for updated xunit plugin on… (#222)
fabc77d 
* Generate xunit files valid for the junit10.xsd (#220)

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

* remove status attribute from result XML (#212)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
nuclearsandwich added a commit that referenced this pull request Apr 11, 2020
@nuclearsandwich @dirk-thomas
[Dashing] Backport junit xml fixes for updated xunit plugin on c… (#224)
ef8ee41 
* Generate xunit files valid for the junit10.xsd (#220)

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

* remove status attribute from result XML (#212)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
kenji-miyake pushed a commit to kenji-miyake/ament_lint that referenced this pull request Oct 20, 2021
Generate xunit files valid for the junit10.xsd (ament#220)
43fe653 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j-rivero @dirk-thomas