Skip to content

Add missing dependency#617

Merged
ahcorde merged 1 commit intoament:rollingfrom
rhaschke:fix-dependency
Feb 17, 2026
Merged

Add missing dependency#617
ahcorde merged 1 commit intoament:rollingfrom
rhaschke:fix-dependency

Conversation

@rhaschke
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke commented Feb 17, 2026

Fixes #616

sloretz
sloretz approved these changes Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Feb 17, 2026

Please sign off the commit to fix the DCO check:

git rebase HEAD~1 --signoff
git push --force-with-lease origin fix-dependency

@rhaschke
Add missing dependency
94aa89d 
Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
@rhaschke
Copy link
Copy Markdown
Contributor Author

rhaschke commented Feb 17, 2026

Ok, configured signoff globally now...

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Feb 17, 2026

Pulls: #617
Gist: https://gist.githubusercontent.com/sloretz/297336f9a81f05ebbde9b64d64e5d61d/raw/a40ce70c8d0c7316bc4b650bee20688a03557c41/ros2.repos
BUILD args: --packages-up-to ament_cmake_python ament_cmake_ros
TEST args: --packages-select ament_cmake_python ament_cmake_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18222

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit b51e3b8 into ament:rolling Feb 17, 2026
3 checks passed
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Feb 17, 2026

@rhaschke should we backport this to older distros ?

@rhaschke
Copy link
Copy Markdown
Contributor Author

rhaschke commented Feb 17, 2026

It's definitely an issue in older distros too, but not a critical one. I easily worked around it. Your decision.

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Feb 18, 2026

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 18, 2026 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Feb 18, 2026
@rhaschke @mergify
Add missing dependency (#617)
d209498 
Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
(cherry picked from commit b51e3b8)
@mergify mergify bot mentioned this pull request Feb 18, 2026
Merged
mergify bot pushed a commit that referenced this pull request Feb 18, 2026
@rhaschke @mergify
Add missing dependency (#617)
4781f3d 
Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
(cherry picked from commit b51e3b8)
@mergify mergify bot mentioned this pull request Feb 18, 2026
Merged
mergify bot pushed a commit that referenced this pull request Feb 18, 2026
@rhaschke @mergify
Add missing dependency (#617)
f2cfed7 
Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
(cherry picked from commit b51e3b8)
@mergify mergify bot mentioned this pull request Feb 18, 2026
Merged
ahcorde pushed a commit that referenced this pull request Feb 19, 2026
@mergify @rhaschke
Add missing dependency (#617) (#619)
449b4bd 
(cherry picked from commit b51e3b8)

Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request Feb 19, 2026
@mergify @rhaschke
Add missing dependency (#617) (#620)
665d1fc 
(cherry picked from commit b51e3b8)

Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request Feb 20, 2026
@mergify @rhaschke
Add missing dependency (#617) (#618)
5f4e82f 
(cherry picked from commit b51e3b8)

Signed-off-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@sloretz sloretz sloretz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ament_cmake_python is missing the dependency to ament_cmake_core

3 participants

@rhaschke @sloretz @ahcorde