Skip to content

add APPEND_ENV and APPEND_LIBRARY_DIRS options to ament_add_*test macros#52

Merged
wjwwood merged 1 commit intomasterfrom
add_test_append_env_option
Dec 31, 2015
Merged

add APPEND_ENV and APPEND_LIBRARY_DIRS options to ament_add_*test macros#52
wjwwood merged 1 commit intomasterfrom
add_test_append_env_option

Conversation

@wjwwood
Copy link
Copy Markdown
Contributor

@wjwwood wjwwood commented Dec 30, 2015

Needed by ros2/rcl#10.

Connects to ros2/rcl#8

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Dec 30, 2015
@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 31, 2015
@esteve
Copy link
Copy Markdown
Contributor

esteve commented Dec 31, 2015

+1

wjwwood added a commit that referenced this pull request Dec 31, 2015
add APPEND_ENV and APPEND_LIBRARY_DIRS options to ament_add_*test macros
@wjwwood wjwwood merged commit a886216 into master Dec 31, 2015
@wjwwood wjwwood deleted the add_test_append_env_option branch December 31, 2015 03:19
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Dec 31, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parser seems to be invalid in this context?

Should this be catched by the caller instead - that would also get rid of the second argument?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wjwwood added a commit that referenced this pull request Jan 7, 2016
firesurfer pushed a commit to firesurfer/ament_cmake that referenced this pull request Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants