Use sysconfig directly to determine python lib dir#378
Merged
Conversation
The distutils package is deprecated and will be removed in Python 3.12. We can achieve the same behavior using sysconfig directly. Signed-off-by: Scott K Logan <logans@cottsay.net>
Contributor
Author
|
nuclearsandwich
approved these changes
Mar 3, 2022
Contributor
nuclearsandwich
left a comment
There was a problem hiding this comment.
sysconfig was added in python 3.2 so is definitely available on supported platforms.
Even though this is backportable I don't see a reason to backport it.
clalancette
approved these changes
Mar 3, 2022
Contributor
Author
I'm not going to champion a backport until we have confidence in this change, but as a non-Ubuntu user, it would be nice to not be assaulted by this message whenever I build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distutils package is deprecated and will be removed in Python 3.12. We can achieve the same behavior using sysconfig directly.
Docs for
get_python_lib: https://docs.python.org/3/distutils/apiref.html#distutils.sysconfig.get_python_libDocs for
get_path: https://docs.python.org/3/library/sysconfig.html#sysconfig.get_pathNote the docs for the
purelibvalue read:This should resolve build warnings like this: