Skip to content

Document _LIBRARY_DIRS lack of support explicitly.#244

Closed
hidmic wants to merge 1 commit intomasterfrom
hidmic/library-dirs-not-used-to-target-deps
Closed

Document _LIBRARY_DIRS lack of support explicitly.#244
hidmic wants to merge 1 commit intomasterfrom
hidmic/library-dirs-not-used-to-target-deps

Conversation

@hidmic
Copy link
Copy Markdown

@hidmic hidmic commented Apr 21, 2020

Precisely what the title says. Connected to #224.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from dirk-thomas April 21, 2020 14:13
# If _INTERFACES is not empty it will be used exclusively, otherwise the other
# variables are being used.
# Packages exporting libraries in non-standard directories cannot rely on a
# _LIBRARY_DIRS variable -- an absolute path to each library must be provided
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A CMake variable ending in _LIBRARY_DIRS is pretty uncommon I think. Did you maybe mean _LIBRARY_DIR instead?

How about checking if a _LIBRARY_DIR variable set and then join it with the library names (assuming these absolute paths exist)?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's the variable that the original issue refers to. It's also the one that's populated by e.g. pkg-config support macros. I cannot seem to find a use case online for a _LIBRARY_DIR variable, which one did you have in mind?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific one. It is just the one I have seen in the past.

How about checking if a _LIBRARY_DIR variable set and then join it with the library names (assuming these absolute paths exist)?

This would still be good to do. The logic would just need to consider all entries in _LIBRARY_DIRS.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To search for the library you mean, right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@hidmic
Copy link
Copy Markdown
Author

hidmic commented Apr 22, 2020

Closing this PR in favor of #245.

@hidmic hidmic closed this Apr 22, 2020
@hidmic hidmic deleted the hidmic/library-dirs-not-used-to-target-deps branch April 22, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants