add CMake function ament_add_test_label()#240
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
There was a problem hiding this comment.
The code LGTM; though personally I would more likely call this once
set_tests_properties(testname PROPERTIES LABELS "xfail;etc")
than append multiple labels with
ament_add_test_label(testname xfail)
ament_add_test_label(testname etc)
since I'll forget what it means in the future, and it's fewer steps to google set_tests_properities() than it is to google ament_add_test_label() followed by set_tests_properites().
But there are many cases were your CMake code in a package doesn't control the test target creation, e.g. https://github.com/ament/ament_index/blob/bfb1aa6f9f958561db616a9fcb84ca9e81e7fef3/ament_index_cpp/CMakeLists.txt#L44 That test target already has a label - If you set your own label on these tests using |
You can also pass multiple labels to the function: |
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
As syntactic sugar for ros2/ros2#900.