Merged
Conversation
Contributor
Author
|
With this change the failing test (outputting non-ASCII characters in the error message) is reported correctly: https://ci.ros2.org/job/ci_windows/7467/testReport/ The actual test is being fixed in a second commit in ros2/rosidl#391. |
jacobperron
reviewed
Jul 19, 2019
| output += decoded_line | ||
| if output_handle: | ||
| output_handle.write(line) | ||
| output_handle.write(decoded_line.encode()) |
Contributor
There was a problem hiding this comment.
Why is this change necessary, isn't line already encoded?
Contributor
Author
There was a problem hiding this comment.
When using line directly it is not ensured that the characters in that string can be encoded into the encoding which is used for stdout.
By first successfully decoding it (with one of the two possible encodings) and then re-encoding it is ensure that the string can be written to stdout without an exception.
jacobperron
approved these changes
Jul 19, 2019
Contributor
jacobperron
left a comment
There was a problem hiding this comment.
Other than one question, LGTM
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2af1579 to
84f395b
Compare
nuclearsandwich
pushed a commit
that referenced
this pull request
Mar 20, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
nuclearsandwich
pushed a commit
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
nuclearsandwich
added a commit
that referenced
this pull request
Apr 11, 2020
* Add runner option to ament_add_test (#174) * ament_cmake allow speficiation of a different test runner - By default, still uses run_test.py - Example use case: ament_cmake_ros can use a test runner that sets a ROS_DOMAIN_ID Signed-off-by: Pete Baughman <pete.baughman@apex.ai> * ament_cmake move run_test.py to a python module - This should let us see the history Signed-off-by: Pete Baughman <pete.baughman@apex.ai> * ament_cmake refactor run_test.py into an importable python module - Adds an ament_cmake_test python package Signed-off-by: Pete Baughman <pete.baughman@apex.ai> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * improve handling of encoding (#181) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * use deterministic order for updated env vars (#196) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Run tests in current binary directory, not global source directory (#206) Switch to CMAKE_CURRENT_BINARY_DIR for consistency with CTest Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * remove status attribute from result XML, add skipped tag instead (#218) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Declare AMENT_TEST_RESULTS_DIR as a PATH (#221) Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Generate xunit files valid for the junit10.xsd Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Revert "Run tests in current binary directory, not global source directory (#206)" This reverts commit 4354d62. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> Co-authored-by: Peter Baughman <dblue135@yahoo.com> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Dan Rose <rotu@users.noreply.github.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ros2/rosidl#388.