-
-
Notifications
You must be signed in to change notification settings - Fork 609
Protocol cleanup (6) #2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Protocol cleanup (6) #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-personified-devil
requested changes
Jul 11, 2025
Collaborator
The-personified-devil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the default thing it lgtm. Also I think the alvr codebase is starting to get quite nice to read thanks to these refactors, especially when considering some older (especially C++) parts.
The-personified-devil
approved these changes
Jul 11, 2025
Jimmy32767255
added a commit
to Jimmy32767255/ALVR-CN
that referenced
this pull request
Aug 28, 2025
commit f14fbfc Author: zmerp <merp.zee@gmail.com> Date: Tue Aug 26 09:09:46 2025 +1000 refactor: :arrow_up: Update dependencies (alvr-org#2986) commit 452452e Author: zmerp <merp.zee@gmail.com> Date: Thu Aug 21 17:12:56 2025 +1000 refactor(common): ♻️ Move popup logic out of alvr_common (alvr-org#2987) commit c3ec94b Author: zmerp <merp.zee@gmail.com> Date: Tue Aug 19 06:39:27 2025 +1000 fix(server_core): :bug: Fix locked webserver during client handshake (alvr-org#2988) commit 7589bb7 Author: zmerp <merp.zee@gmail.com> Date: Mon Aug 18 00:32:25 2025 +1000 refactor(graphics): ⬆️ Update wgpu tp v25 (alvr-org#2982) commit 343618b Author: zmerp <merp.zee@gmail.com> Date: Wed Aug 13 03:05:49 2025 +1000 feat(dashboard): :sparkles: Add "Clear all" button in Logs tab (alvr-org#2983) commit f0c0516 Author: Leonhard Saam <54042101+The-personified-devil@users.noreply.github.com> Date: Sun Aug 10 04:05:40 2025 +0200 ci: fully fix merge queues (alvr-org#2980) - disable the checks on push as the merge queue ones do their job fully commit 93c5b43 Author: Leonhard Saam <54042101+The-personified-devil@users.noreply.github.com> Date: Sat Aug 9 16:46:45 2025 +0200 ci: fix merge-queue actions (alvr-org#2978) commit 12e6589 Author: Leonhard Saam <54042101+The-personified-devil@users.noreply.github.com> Date: Fri Aug 8 15:18:43 2025 +0200 fix: bump cpal+rodio, fix os error 11 timeout (alvr-org#2944) - fix cpal device enumeration being extremely slow on v0.15 - actually respect virtual audio cable search ordering - don't store is_output property - compare devices based on id - remove AudioDevice struct commit 5d017a1 Author: Leonhard Saam <54042101+The-personified-devil@users.noreply.github.com> Date: Fri Aug 8 15:16:04 2025 +0200 ci: make rarely triggering checks run on merge queue only (alvr-org#2973) commit a211bad Author: zmerp <merp.zee@gmail.com> Date: Fri Aug 8 03:33:32 2025 +0200 refactor: :rotating_light: Fix Rust v1.89 lints (alvr-org#2972) commit 7757a8b Author: micsthepick <11528421+micsthepick@users.noreply.github.com> Date: Wed Aug 6 11:00:21 2025 +1000 fix client stream.wgsl shader (alvr-org#2962) commit 33a90ab Author: Meister1593 <leruop@Gmail.com> Date: Sat Aug 2 02:43:58 2025 +0000 fix (dashboard): Fix incorrect AV1 gpu in note alvr-org#2331, add more information about headsets (alvr-org#2949) commit ec947a0 Author: zmerp <merp.zee@gmail.com> Date: Fri Aug 1 17:30:14 2025 +0200 fix(xtask): :pushpin: Pin cargo-ndk to previous version (alvr-org#2954) commit a67c4e3 Author: zmerp <merp.zee@gmail.com> Date: Thu Jul 31 23:24:52 2025 +0200 Protocol cleanup (8): binary protocol refactoring (alvr-org#2932) commit 6db106f Author: zmerp <merp.zee@gmail.com> Date: Tue Jul 22 19:14:15 2025 +0200 fix(dashboard): :bug: Fix unexpected version popup (alvr-org#2929) commit 94ea7db Author: zmerp <merp.zee@gmail.com> Date: Tue Jul 22 15:52:38 2025 +0200 Protocol cleanup (7): Reserved to normal packet variants (alvr-org#2915) commit 1fb60d1 Author: Meister1593 <leruop@Gmail.com> Date: Sat Jul 19 20:20:46 2025 +0000 Pipewire implementation refactor (alvr-org#2902) * refactor(linux,audio): Refactor pipewire audio, exit early if pipewire is not found and inform user * refactor(linux,audio): simplify logic, add check for pipewire before starting receiving or sending data * refactor(linux,audio): leftover small refactors, remove clippy macros * refactor(linux,audio): add flatpak note, try initing more pipewire functions to trigger error, moved try pipewire earlier to abort all audio processing early * refactor(linux,audio,flatpak) Added check for pipewire early in dashboard launch, reformatting output * refactor(linux,audio): reduce nesting * revert unnecessary change * remove unnecessary nesting * reformat string * reformat string * clippy, format, macos fixes * clippy linux gate fixes * chore: Refactor pipewire impl some more * Address review comments; simplify pw flatpak check * fix: fix bug in pw playback + speed up buffer filling * reverse pw socket check * add check for pipewire being a socket or an empty file * light refactor to simplify * address comments in pr: invert logic for socket check again and simplify code, add comment related to state changes in pipewire causing cut out * format fix * fix typo --------- Co-authored-by: Leonhard Saam <leonhard.saam@yahoo.com> commit 222ae53 Author: Dagg <dagg@kyzune.com> Date: Mon Jul 14 23:33:37 2025 -0700 Implement high fidelity IOBT (XR_META_body_tracking_fidelity) for Quest 3 (alvr-org#2917) * Sync Files * Implement xrRequestBodyTrackingFidelityMETA * Formatting * Fix warnings * Removed maxenum value Probably not necessary now that i think about it * Cleanup and renaming * Add config option * Fix formatting * Explicitly set fidelity mode based on config value, don't bail on mode set fail. * Swap closure for if let, and_then * Bail if request method is missing, force Ok from mode set. --------- Co-authored-by: GitHub Action <action@github.com> commit 80796e2 Author: Riccardo Zaglia <riccardo.zaglia5@gmail.com> Date: Tue Jul 15 02:19:14 2025 +1000 fix(ci): :green_heart: Fix CI release workflow commit 8c72354 Author: zmerp <merp.zee@gmail.com> Date: Sun Jul 13 16:51:54 2025 +0200 fix(dashboard): :bug: Remove devices from Headset speaker dropdown (alvr-org#2918) commit 8c0a815 Author: zmerp <merp.zee@gmail.com> Date: Fri Jul 11 15:54:48 2025 +0200 Protocol cleanup (6) (alvr-org#2912) * Protocol cleanup (6) * Don't impl Default for BodyTrackingBDConfig commit 6fa03e9 Author: zmerp <merp.zee@gmail.com> Date: Fri Jul 11 06:32:06 2025 +0200 fix(audio): :bug: Fix input/output audio device handling (alvr-org#2911) commit 4e08e0e Author: zmerp <merp.zee@gmail.com> Date: Thu Jul 10 20:39:05 2025 +0200 Protocol cleanup (5) (alvr-org#2907) # Conflicts: # alvr/dashboard/src/dashboard/components/settings_controls/presets/builtin_schema.rs resolved by origin/master(远端) version # alvr/session/src/settings.rs resolved by origin/master(远端) version # wiki/Installation-guide.md resolved by origin/master(远端) version # wiki/Installing-ALVR-and-using-SteamVR-on-Linux-through-Flatpak.md resolved by origin/master(远端) version # wiki/Other-resources.md resolved by origin/master(远端) version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last piece from #2901
Tested on Quest 3/Windows