fix(server_openvr): ✨ Conditional HMD initialization strategy #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e70789 to
1abde75
Compare
Member
Author
|
Should be ready for review |
Merged
The-personified-devil
requested changes
Jun 29, 2025
The-personified-devil
previously approved these changes
Jun 29, 2025
21a8234 to
549df7f
Compare
Member
Author
|
Sorry, I ran cargo xtask format but not cargo clippy... |
The-personified-devil
approved these changes
Jun 29, 2025
zmerp
added a commit
that referenced
this pull request
Jun 29, 2025
* fix(server_openvr): ⏪ Revert HMD initialization at driver startup * Initialize HMD early only when dashboard is alive * Address review comments
zmerp
added a commit
that referenced
this pull request
Jun 30, 2025
* fix(server_openvr): ⏪ Revert HMD initialization at driver startup * Initialize HMD early only when dashboard is alive * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR i add a parameter to
register_deviceto not wait for device activation; this is required for how the code is structured now. SteamVR wants us to do this asynchronously anyway but it was easier for me in the previous PR to force it back to be synchronous. Even though now the code could be racy, I've tested this PR and there seems to be no problem, even in the case of fastest client connection (when the client is already awake waiting and already trusted in the server).