fix(dashboard): 🐛 Fix version popup #2872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
commented
Jun 27, 2025
Comment on lines
+7
to
+10
| pub enum CloseAction { | ||
| Close, | ||
| CloseWithRequest(ServerRequest), | ||
| } |
Member
Author
There was a problem hiding this comment.
I opted for this enum instead of Option to be more clear. Nested Options is never a good idea.
The-personified-devil
approved these changes
Jun 27, 2025
Comment on lines
+1551
to
1553
| pub struct NewVersionPopupConfig { | ||
| pub hide_while_version: String, | ||
| } |
Collaborator
There was a problem hiding this comment.
This isn't exactly great instead of just directly putting the String there, but ig it's fine? Idk how else to nicely document that that's the meaning
Member
Author
There was a problem hiding this comment.
Yeah that was my thought process. If I used directly string, the parent field would have to convey the meaning, but in this case it was too complex to express. I think as it is now it's more ergonomic for the user.
zmerp
added a commit
that referenced
this pull request
Jun 28, 2025
Merged
zmerp
added a commit
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last refactor before merging broke a couple of things, plus I changed to a different settings format
Tested and working using stable and -dev versions