fix: Add/restore missing fake Vive trackers #2870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
approved these changes
Jun 27, 2025
Member
zmerp
left a comment
There was a problem hiding this comment.
Ah thanks, looks good to me. The CI failures are due to an update of Rust that added new lints.
zmerp
pushed a commit
that referenced
this pull request
Jun 27, 2025
Merged
zmerp
pushed a commit
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2869.
apparently, during one of refactors, those 4 lines for
/device/ALVR/tracker/left_elbowand/device/ALVR/tracker/right_elbowwere missed and flew under radar unnoticed since pico FBT support was ever introduced. this PR adds those missing lines, bringing back fake trackers for elbows.