fix(firewall): linux firewalld zones being parsed incorrectly #2845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Do you have an example of some output from firewalld where it fails? Because blind reviewing regexes is really hard |
Collaborator
Author
Not exactly blind, i did test it locally with firewalld on my machine, tried adding more active zones, checked through regex, it's working as intended now. |
Collaborator
|
Well yea, but I don't have that information to check it, tho ig that does it now. |
The-personified-devil
approved these changes
Jun 9, 2025
zmerp
pushed a commit
that referenced
this pull request
Jun 27, 2025
Merged
zmerp
pushed a commit
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2250
Seems like it was incorrect regex being used, not parsing all zones from list of active zones (including public, or any that had other words in line)