fix(dashboard): UIX Improvements to dashboard settings #2840
Conversation
… added more collapsible by default sections
zmerp
left a comment
There was a problem hiding this comment.
I don't have time to review or test thoroughly, but it seems mostly good to me. Small nit, even though nothing changes functionally, you should move #[cfg_attr] attribute before #[schema] because the latter would be rendered useless by the former. It doesn't change functionally because Rust parses all attributes at once before executing their code
|
I'm sorry but renaming it in the codebase is just a big mess, please revert that. Software encoding is more technically correct because if you have an igpu in the cpu (often it's not even part of the igpu it's it's own thing next to the other things) then that could also be understood as cpu encoding. I'm fine with renaming it for user facing stuff because it might be be less confusing to users, but I'm also not exactly happy there, I think a middle group might be changing it to |
Ok for codebase rename, i just wanted to make it consistent across the board (and it's anyway just strings rename, nothing special) To be honest we can easily ask community for the best option in discord as a poll
|
|
Yea I think that's too small for a poll. My opinion is just that most people likely won't be thrown off by another term being there, but people that only get one will understand what's going on. Essentially more helps more, so my preferred choice would be 'Software (CPU encoding', but I'm not hard on that. But the codebase rename is giving me a stroke, I can't merge that. |
Let's just leave it at |
* fix(dashboard): platform-specific settings are now shown only on specific platforms * fix(dashboard): renamed common amd and amf parameters, moved to different sections * fix(dashboard): separated hdr section, separated quality preset/vbaq, added more collapsible by default sections * fix(dashboard): after modification presets fix * fix(dashboard): adjust strings in settings, hide windows-only adapter index on linux * fix format * review platform cfgs adjust * review fixes * review fixes #2 * review fixes #3 - renamed software encoding to cpu encoding * format fix * changed software to cpu encoding in docs, notifications, remaining code * fix format * Revert "fix format" This reverts commit 0170f0e. * Revert "changed software to cpu encoding in docs, notifications, remaining code" This reverts commit fae2ba3. * Revert "format fix" This reverts commit c7a47be. * Revert "review fixes #3 - renamed software encoding to cpu encoding" This reverts commit 89a1fb3. * rename category to Software (CPU) encoding * review fixes - change to windows specific, not on linux * review fixes - remove windows specific hide, change string
* fix(dashboard): platform-specific settings are now shown only on specific platforms * fix(dashboard): renamed common amd and amf parameters, moved to different sections * fix(dashboard): separated hdr section, separated quality preset/vbaq, added more collapsible by default sections * fix(dashboard): after modification presets fix * fix(dashboard): adjust strings in settings, hide windows-only adapter index on linux * fix format * review platform cfgs adjust * review fixes * review fixes #2 * review fixes #3 - renamed software encoding to cpu encoding * format fix * changed software to cpu encoding in docs, notifications, remaining code * fix format * Revert "fix format" This reverts commit 0170f0e. * Revert "changed software to cpu encoding in docs, notifications, remaining code" This reverts commit fae2ba3. * Revert "format fix" This reverts commit c7a47be. * Revert "review fixes #3 - renamed software encoding to cpu encoding" This reverts commit 89a1fb3. * rename category to Software (CPU) encoding * review fixes - change to windows specific, not on linux * review fixes - remove windows specific hide, change string
Changed names for amf or other section variables accordingly across codebase
Changed some strings in dashboard and moved values around for easier access/readability
Changed some sections to be collapsible (and by default) to save space and better readability
Moved sections around (hdr into own category, amd/amf/vaapi settings separated)
Hid most (if not all) windows-only sections on linux and linux-only on other platforms