fix(dashboard): 🐛 Fix theme when system is set to light #2763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-personified-devil
approved these changes
Mar 19, 2025
Collaborator
The-personified-devil
left a comment
There was a problem hiding this comment.
I mean supporting both a light and dark theme in the future might be nice but for the time being this lgtm
Member
Author
|
While first developing the dashboard, there was a discussion and the conclusion is that we don't need a light mode, we can spare the effort for something else. Of course I'm not completely opposed if someone would make a PR for this |
zmerp
added a commit
that referenced
this pull request
Jun 27, 2025
Merged
zmerp
added a commit
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces the theme to Dark instead of System
Closes #2760
Supersedes #2761