feat: ✨ Add eye and lip tracking on Vive #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd7f196 to
7172a49
Compare
7172a49 to
0bd3efc
Compare
The-personified-devil
approved these changes
Feb 23, 2025
Collaborator
The-personified-devil
left a comment
There was a problem hiding this comment.
LGTM, apart from that one subjective nit
Comment on lines
+35
to
+46
| let expression_count = if facial_tracking_type == sys::FacialTrackingTypeHTC::EYE_DEFAULT | ||
| && props.support_eye_facial_tracking.into() | ||
| { | ||
| sys::FACIAL_EXPRESSION_EYE_COUNT_HTC | ||
| } else if facial_tracking_type == sys::FacialTrackingTypeHTC::LIP_DEFAULT | ||
| && props.support_lip_facial_tracking.into() | ||
| { | ||
| sys::FACIAL_EXPRESSION_LIP_COUNT_HTC | ||
| } else { | ||
| return Err(sys::Result::ERROR_FEATURE_UNSUPPORTED); | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
This is a bit hard to understand, maybe a match would be better? And/or actually nesting the conditions
Member
Author
There was a problem hiding this comment.
I'm not sure you can make this any better with a match, we are checking different variables for each branch
| ))?; | ||
|
|
||
| if facial_expressions.is_active.into() { | ||
| weights.set_len(self.expression_count); |
Collaborator
There was a problem hiding this comment.
I'm truly surprised, but apparently this is the right way to do ffi with vectors 👍
zmerp
added a commit
that referenced
this pull request
Mar 9, 2025
* feat: ✨ Add eye and lip tracking on Vive * log htc face data in lobby * undo debugging changes + minor refactoring * force initialization at startup --------- Co-authored-by: Awzri <awzri@awzricat.com>
Merged
zmerp
added a commit
that referenced
this pull request
Mar 11, 2025
* feat: ✨ Add eye and lip tracking on Vive * log htc face data in lobby * undo debugging changes + minor refactoring * force initialization at startup --------- Co-authored-by: Awzri <awzri@awzricat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and working on the Focus Vision. because of a limitation of the runtime, the tracker objects can only be initialized at startup.