Skip to content

Conversation

@zmerp
Copy link
Member

@zmerp zmerp commented Jan 16, 2025

No description provided.

@zmerp
Copy link
Member Author

zmerp commented Jan 17, 2025

I would like some feedback on the min/max/step of the setting

@zmerp
Copy link
Member Author

zmerp commented Jan 18, 2025

Ready

Copy link
Collaborator

@The-personified-devil The-personified-devil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I've honestly lost track of changing what where would cause a protocol break, so if you think that aspect's fine then it's good

@zmerp
Copy link
Member Author

zmerp commented Jan 18, 2025

LGTM, but I've honestly lost track of changing what where would cause a protocol break, so if you think that aspect's fine then it's good

Sometimes it's not so straightforward to identify and sometimes it could be controversial. In this case the changes are unilateral on the client and don't have any consequence on the server side. the setting is on the server side but with our mechanisms of session extrapolation it doesn't become a breaking change.

@zmerp zmerp merged commit 66bbc3c into master Jan 18, 2025
8 checks passed
zmerp added a commit that referenced this pull request Jan 18, 2025
…ng off (#2635)

* fix(client_core): 🐛 Cap prediction to avoid head and controllers flying off

* Add Max prediction setting
@zmerp zmerp mentioned this pull request Jan 18, 2025
zmerp added a commit that referenced this pull request Jan 18, 2025
…ng off (#2635)

* fix(client_core): 🐛 Cap prediction to avoid head and controllers flying off

* Add Max prediction setting
omfatimh38

This comment was marked as abuse.

omfatimh38

This comment was marked as abuse.

@The-personified-devil
Copy link
Collaborator

@omfatimh38 Would you mind explaining to me what you're doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants