Skip to content

Conversation

@failboat78
Copy link
Collaborator

Flatpak launcher was previously downloading a specific version of binary. Change this so it now does an in-tree build.

TODO: cicd integration (put version number into json?)

@failboat78 failboat78 marked this pull request as ready for review September 11, 2024 17:49
@zmerp zmerp requested a review from Meister1593 September 12, 2024 21:34
@The-personified-devil
Copy link
Collaborator

The-personified-devil commented Sep 13, 2024

per se fine, unsure about that version thing tho fully lgtm

@The-personified-devil The-personified-devil merged commit 6b29398 into alvr-org:master Sep 14, 2024
@failboat78 failboat78 deleted the flatpak_launcher branch September 14, 2024 10:25
zmerp pushed a commit that referenced this pull request Sep 20, 2024
* build the launcher inside flatpak, rather than downloading it

* change versio number in desktop shortcut to 1.0 (this is version of launcher, not version of alvr)

---------

Co-authored-by: failboat <failboat@ocean.world>
zmerp pushed a commit that referenced this pull request Sep 20, 2024
* build the launcher inside flatpak, rather than downloading it

* change versio number in desktop shortcut to 1.0 (this is version of launcher, not version of alvr)

---------

Co-authored-by: failboat <failboat@ocean.world>
@zmerp zmerp mentioned this pull request Sep 20, 2024
zmerp pushed a commit that referenced this pull request Sep 21, 2024
* build the launcher inside flatpak, rather than downloading it

* change versio number in desktop shortcut to 1.0 (this is version of launcher, not version of alvr)

---------

Co-authored-by: failboat <failboat@ocean.world>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants