feat: ✨ Add debug groups #2332
Merged
feat: ✨ Add debug groups #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Should I also populate logs in this PR for some or all of the groups I implemented? |
Member
|
Will this be available in "release" mode built server/client_core ? |
Member
Author
|
The groups are only for the debug level which is gated out when compiling in release mode. If you intend to have logs also on release mode then you need to use info or up, and it should not be spammy |
c1bf157 to
386fb36
Compare
The-personified-devil
approved these changes
Aug 20, 2024
szneqz
pushed a commit
to szneqz/ALVR
that referenced
this pull request
Aug 21, 2024
* feat: ✨ Add debug groups * Expose logging to c apis * Hide debug groups settings in release mode * Use dbg macros instead of functions * Rename "handshake" to "connection" * Populate client_core, sever_core and connection debug groups
zmerp
added a commit
that referenced
this pull request
Sep 10, 2024
* feat: ✨ Add debug groups * Expose logging to c apis * Hide debug groups settings in release mode * Use dbg macros instead of functions * Rename "handshake" to "connection" * Populate client_core, sever_core and connection debug groups
Merged
zmerp
added a commit
that referenced
this pull request
Sep 10, 2024
* feat: ✨ Add debug groups * Expose logging to c apis * Hide debug groups settings in release mode * Use dbg macros instead of functions * Rename "handshake" to "connection" * Populate client_core, sever_core and connection debug groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I thought about using the tracing crate, but for now there are no strong reasons to do it. Could be slightly cleaner to use attributes for function scopes. In any case the switch can be done at a later moment.