Fix a couple of segfaults on linux #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
approved these changes
May 5, 2024
Member
zmerp
left a comment
There was a problem hiding this comment.
Looks alright, but we require someone that can test on Linux
zmerp
pushed a commit
that referenced
this pull request
May 7, 2024
* lots of fixes * remove unique_ptr from matInv33 * debug output removings * remove unwanted formatting * remove unwanted formatting * fix formatting attempt * remove cache --------- Co-authored-by: Nikita Morozov <mornickmyl@gmail.com>
Merged
zmerp
pushed a commit
that referenced
this pull request
May 7, 2024
* lots of fixes * remove unique_ptr from matInv33 * debug output removings * remove unwanted formatting * remove unwanted formatting * fix formatting attempt * remove cache --------- Co-authored-by: Nikita Morozov <mornickmyl@gmail.com>
Closed
4 tasks
|
Also fixed issue for me #2070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem 1: unique_ptrs in matInv33 was not initialized correctly with make_unique, which led to segfaults on attempt to use nullptr.
Problem 2: VRChaperoneSetup, VRSettings and VRCompositor functions sometimes still return nullptr despite that openvr is initialized. It also leads to segfaults on attempts to use that pointers.
Problem 3: cpal sometimes uses
pactlcmd line tool on linux which will not be available ifpulseaudio-utilspackage is not installed