Configure AssetHelper to load individual stylesheets#1622
Merged
jon-kirwan merged 2 commits intomainfrom Mar 30, 2023
Merged
Conversation
336b5ae to
ab8e1f7
Compare
MartinJJones
approved these changes
Mar 30, 2023
Contributor
MartinJJones
left a comment
There was a problem hiding this comment.
Changes look good to me 👍
ab8e1f7 to
15e0f2b
Compare
15e0f2b to
1179ab6
Compare
jon-kirwan
approved these changes
Mar 30, 2023
Rosa-Fox
added a commit
that referenced
this pull request
Apr 12, 2023
Updated due to a rebase from the main branch which changed how CSS components are loaded. The new way of loading individual components: https://github.com/alphagov/govuk_publishing_components/blob/main/docs/set-up-individual-component-css-loading.md PR that introduced the change: #1622
Rosa-Fox
added a commit
that referenced
this pull request
Apr 12, 2023
Updated due to a rebase from the main branch which changed how CSS components are loaded. The new way of loading individual components: https://github.com/alphagov/govuk_publishing_components/blob/main/docs/set-up-individual-component-css-loading.md PR that introduced the change: #1622
Rosa-Fox
added a commit
that referenced
this pull request
May 5, 2023
Updated due to a rebase from the main branch which changed how CSS components are loaded. The new way of loading individual components: https://github.com/alphagov/govuk_publishing_components/blob/main/docs/set-up-individual-component-css-loading.md PR that introduced the change: #1622
Rosa-Fox
added a commit
that referenced
this pull request
May 31, 2023
Updated due to a rebase from the main branch which changed how CSS components are loaded. The new way of loading individual components: https://github.com/alphagov/govuk_publishing_components/blob/main/docs/set-up-individual-component-css-loading.md PR that introduced the change: #1622
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
https://trello.com/c/76GY8acK/1906-enable-individual-loading-of-stylesheets-in-feedback
Changes to load component and view style sheets only required on the page being viewed. For example, CSS for "radio" only loads on the following pages:
Why
This reduces the amount of CSS required for each page and increases the ability of a browser to cache the stylesheets - this should mean a faster load time for both first time and repeat visitors.
See RFC #149 for more details.
Review URL(s)
Visual changes
None
Anything else
application.scssonly includes the following settings (below) which can be removed since they are included with_individual_component_support.scss(imported fromgovuk_publishing_components) andapplication.scsscan then be removed