Skip to content

refactor(almin): use Dispatcher insteadof events#349

Closed
azu wants to merge 1 commit intomasterfrom
use-dispatcher-insteadof-payload
Closed

refactor(almin): use Dispatcher insteadof events#349
azu wants to merge 1 commit intomasterfrom
use-dispatcher-insteadof-payload

Conversation

@azu
Copy link
Copy Markdown
Member

@azu azu commented Jun 9, 2018

Use Dispatcher class insteadof events.

We will remove the dependencies to events in the future.

Pros

  • Reduce file size
  • Perf?
  • React Native compatible
    • React Native bundler does not includes events by default

@azu azu force-pushed the use-dispatcher-insteadof-payload branch from ae7997e to d92be3a Compare June 9, 2018 06:13
@azu
Copy link
Copy Markdown
Member Author

azu commented Jun 9, 2018

I found a problem.
Store class use the emit and dispatach quite differently.

@azu azu mentioned this pull request Jun 9, 2018
Closed
@azu
Copy link
Copy Markdown
Member Author

azu commented Aug 25, 2018

Transfer to #357

@azu azu closed this Aug 25, 2018
@azu azu deleted the use-dispatcher-insteadof-payload branch August 25, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@azu