Skip to content

refactor(almin): Replace "events" to Events.ts#357

Merged
azu merged 5 commits intomasterfrom
use-internal-events
Aug 25, 2018
Merged

refactor(almin): Replace "events" to Events.ts#357
azu merged 5 commits intomasterfrom
use-internal-events

Conversation

@azu
Copy link
Copy Markdown
Member

@azu azu commented Aug 25, 2018

Drop to use Node.js's events aka. EventEmitter.
Use Events.ts instead of it.

Purpose

  • Reduce file size
  • Reduce dependencies
  • React Native compatible
    • React Native bundler does not includes events by default

Resuls

File Size(gzip):

- 8.5 KB
+ 7.69 KB

fix #352

typeof performance.clearMeasures === "function";

export class AlminPerfMarker extends EventEmitter implements AlminPerfMarkerAbstract {
export type AlminPerfMarkerActions =
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we use enum

@azu azu force-pushed the use-internal-events branch from d3cc370 to e6e49f1 Compare August 25, 2018 10:28
@azu azu force-pushed the use-internal-events branch from e6e49f1 to f06322c Compare August 25, 2018 10:34
@azu azu merged commit 864e2f7 into master Aug 25, 2018
@azu azu deleted the use-internal-events branch August 25, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop to use events

1 participant