fix(React): Use componentDidMount instead of componentWillMount#321
Merged
azu merged 2 commits intoalmin:masterfrom Jan 19, 2018
Merged
fix(React): Use componentDidMount instead of componentWillMount#321azu merged 2 commits intoalmin:masterfrom
azu merged 2 commits intoalmin:masterfrom
Conversation
Member
Almin project use Conventional Commits. (We want to improve CONTRIBUTING Guide too) If the scope is difference, you should separate commits. FYI: my other project describe this context in detail. https://github.com/textlint/textlint/blob/master/docs/CONTRIBUTING.md#git-commit-message-format Can you separate the commit into follows?
Actually, lerna use this commit message for generating CHANGELOG and versioning. |
Member
A single PR includes multiple commits is OK. |
Member
|
FYI: I've updated commit message style document #322 |
Contributor
Author
|
@azu Thank you for your help! I've fixed it. |
Member
|
Thanks! |
Contributor
Author
|
Thank you! |
azu
added a commit
that referenced
this pull request
Feb 24, 2018
We have used componentDidMount instead of componentWillMount in #321 But, Almin React Container should be initialized before other component. Because, this component subscribe `Context#onChange`. In other words, Almin React Container can not handle `Context#onchange` when some store has been changed in Other Component#componentDidMount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React is going to deprecate
componentWillMountso Almin should usecomponentDidMountinstead ofcomponentWillMount.This PR includes fixes for documentation and an example and a source of
almin-react-container.Should I separate this PR each one?