feat(rpc): Add OpTransactionRequest and associate it with TransactionRequest of Optimism#557
Merged
feat(rpc): Add OpTransactionRequest and associate it with TransactionRequest of Optimism#557
OpTransactionRequest and associate it with TransactionRequest of Optimism#557Conversation
…ionRequest` of `Optimism`
mattsse
approved these changes
Jun 25, 2025
Member
mattsse
left a comment
There was a problem hiding this comment.
lgtm
pending @klkvr
@yash-atreya for context, it turns out that unifying the type leads to some ambiguity, and makes the transactionBuilder api worse when operating on the request type because then all functions require a network hint...
klkvr
approved these changes
Jun 25, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…ionRequest` of `Optimism` (alloy-rs/op-alloy#557) ## Motivation The change #525 introduced ambiguity of `alloy_network::TransactionBuilder` implementation for `TransactionRequest`, being implemented twice once for `Ethereum` and once for `Optimism`. This then requires fully qualified syntax to differentiate. ## Solution Bring back `OpTransactionRequest` ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The change #525 introduced ambiguity of
alloy_network::TransactionBuilderimplementation forTransactionRequest, being implemented twice once forEthereumand once forOptimism. This then requires fully qualified syntax to differentiate.Solution
Bring back
OpTransactionRequestPR Checklist