feat(consensus): Add as_deposit into OpTransaction trait#549
Merged
RomanHodulak merged 1 commit intomainfrom Jun 16, 2025
Merged
feat(consensus): Add as_deposit into OpTransaction trait#549RomanHodulak merged 1 commit intomainfrom
as_deposit into OpTransaction trait#549RomanHodulak merged 1 commit intomainfrom
Conversation
mattsse
reviewed
Jun 16, 2025
93bec8f to
d8def4e
Compare
mattsse
approved these changes
Jun 16, 2025
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
…550) Follow-up on #549 ## Motivation The RPC transaction object has a dedicated conversion function that accepts `OpTxEnvelope` struct. But it cannot be used with a transaction that is not `OpTxEnvelope` but implements `OpTransaction`. ## Solution Since `OpTransaction` provides all the needed functionality for the conversion, replace the `OpTxEnvelope` type with a generic type. ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…s/op-alloy#549) Follow-up on #548 ## Motivation `OpTransaction` trait can tell if its deposit, but that is not very useful if I also need to extract it. ## Solution Add `as_deposit` function into the trait for the extraction of `TxDeposit`. ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #548
Motivation
OpTransactiontrait can tell if its deposit, but that is not very useful if I also need to extract it.Solution
Add
as_depositfunction into the trait for the extraction ofTxDeposit.PR Checklist