chore: implement serde_bincode_compat for envelope#486
Merged
mattsse merged 2 commits intoalloy-rs:mainfrom Apr 3, 2025
Merged
chore: implement serde_bincode_compat for envelope#486mattsse merged 2 commits intoalloy-rs:mainfrom
mattsse merged 2 commits intoalloy-rs:mainfrom
Conversation
mattsse
approved these changes
Apr 3, 2025
| /// Transaction signature. | ||
| signature: Signature, | ||
| /// Borrowed EIP-1559 transaction data. | ||
| #[serde(borrow)] |
Member
There was a problem hiding this comment.
ah nice, this way we dont neven need a cow, never thought about this and now I feel stupid :)
Contributor
Author
There was a problem hiding this comment.
Super cool, right!
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…#486) - This PR also helps close out paradigmxyz/reth#15377 - Related implementation: alloy-rs/alloy#2263 - Running test via `cargo test --features "serde serde-bincode-compat arbitrary k256" test_op_tx_envelope_bincode_roundtrip_arbitrary` shows successful test. Please lmk if it's robust enough or if there's some pointers to make this implementation more extensive 🤙 - Note that you'll need `alloy-consensus = { workspace = true, features = ["serde", "serde-bincode-compat" ] }` and `[features] default = ["std", "serde", "serde-bincode-compat", "arbitrary"]` in the `Cargo.toml` --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo test --features "serde serde-bincode-compat arbitrary k256" test_op_tx_envelope_bincode_roundtrip_arbitraryshows successful test. Please lmk if it's robust enough or if there's some pointers to make this implementation more extensive 🤙alloy-consensus = { workspace = true, features = ["serde", "serde-bincode-compat" ] }and[features] default = ["std", "serde", "serde-bincode-compat", "arbitrary"]in theCargo.toml