Skip to content

feat: add additional compat impls#427

Merged
mattsse merged 4 commits intomainfrom
matt/add-alloy-compat
Feb 12, 2025
Merged

feat: add additional compat impls#427
mattsse merged 4 commits intomainfrom
matt/add-alloy-compat

Conversation

@mattsse
Copy link
Copy Markdown
Member

@mattsse mattsse commented Feb 11, 2025

blocked by alloy-rs/alloy#2042

turns out we dont need this

adds some conversion helpers for txdepoist

@cakevm
Copy link
Copy Markdown

cakevm commented Feb 12, 2025

I am really looking forward to this change. I wanted to let you know that I have created a minimal example for testing here: https://github.com/cakevm/alloy-to-reth-primitives/blob/main/src/main.rs The idea here is that it makes testing ExEx easier by fetching blocks from RPC and ingesting them into Reth. Like the benchmark in reth is doing.

PS: Maybe it makes sense to get rid of some feature flags from reth-optimism-primitives to be on par with the reth-ethereum-primitivescrate.

@mattsse
Copy link
Copy Markdown
Member Author

mattsse commented Feb 12, 2025

Maybe it makes sense to get rid of some feature flags from reth-optimism-primitives to be on par with the reth-ethereum-primitivescrate.

such as?
could you perhaps summarize this in a reth issue?

@mattsse mattsse marked this pull request as ready for review February 12, 2025 16:09
@mattsse
Copy link
Copy Markdown
Member Author

mattsse commented Feb 12, 2025

@cakevm
Copy link
Copy Markdown

cakevm commented Feb 12, 2025

Maybe it makes sense to get rid of some feature flags from reth-optimism-primitives to be on par with the reth-ethereum-primitivescrate.

such as? could you perhaps summarize this in a reth issue?

It is really a minor thing. Maybe I am also missing something, but it feels odd that I require different features for the same functionality. But probably I miss some other dependencies why this is required. When I have I bigger picture I can open a issue of course.

As you can see in the example:

# eth-reth
reth-ethereum-primitives = { git = "https://github.com/paradigmxyz/reth", rev = "1e0b0d8", features = [
  "reth-codec"
] }

# op-reth
reth-optimism-primitives = { git = "https://github.com/paradigmxyz/reth", rev = "1e0b0d8", features = [
  "alloy-compat",
  "optimism",
  "reth-codec",
  "serde",
] }

@mattsse
Copy link
Copy Markdown
Member Author

mattsse commented Feb 12, 2025

there's currently a limitation where some reth crates are incompatible dues to revm optimism features, this will go away within the next few weeks and then we can combine all of this

@mattsse mattsse merged commit 8ef160e into main Feb 12, 2025
21 checks passed
@mattsse mattsse deleted the matt/add-alloy-compat branch February 12, 2025 19:13
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 21, 2026
~~blocked by alloy-rs/alloy#2042

turns out we dont need this

adds some conversion helpers for txdepoist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants