Skip to content

feat(protocol): Span Batch Signature Type#192

Closed
refcell wants to merge 3 commits intorf/feat/batch-utilsfrom
rf/feat/span-batch-signature
Closed

feat(protocol): Span Batch Signature Type#192
refcell wants to merge 3 commits intorf/feat/batch-utilsfrom
rf/feat/span-batch-signature

Conversation

@refcell
Copy link
Copy Markdown
Collaborator

@refcell refcell commented Oct 28, 2024

Description

Ports the span batch signature type to op-alloy-protocol.

Provenance

Part of a port migrating the batch types from kona-derive to op-alloy. See kona#695.

@refcell refcell requested a review from mattsse as a code owner October 28, 2024 00:06
@refcell
Copy link
Copy Markdown
Collaborator Author

refcell commented Oct 28, 2024

Copy link
Copy Markdown
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference between this and Signature?

@refcell refcell force-pushed the rf/feat/batch-utils branch from 07ac367 to 3e9bba1 Compare October 28, 2024 12:55
@refcell
Copy link
Copy Markdown
Collaborator Author

refcell commented Oct 28, 2024

what is the difference between this and Signature?

I think we can remove this and just use Signature.

@refcell refcell closed this Oct 28, 2024
@refcell refcell deleted the rf/feat/span-batch-signature branch November 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants