chore: replace Signature with PrimitiveSignature#796
Merged
Conversation
This was referenced Oct 30, 2024
klkvr
added a commit
that referenced
this pull request
Oct 31, 2024
ZelionD
pushed a commit
to ZelionD/core
that referenced
this pull request
Nov 11, 2024
* chore: replace Signature with PrimitiveSignature * fmt
ZelionD
pushed a commit
to ZelionD/core
that referenced
this pull request
Nov 11, 2024
Revert "chore: replace Signature with PrimitiveSignature (alloy-rs#796)" This reverts commit 9856a37.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ref #776
Removes
Paritytype and replacesSignaturewithPrimitiveSignatureThis should go into next breaking release
Solution
PR Checklist