Implement is_zero method for U64HexOrNumber#478
Merged
Conversation
mattsse
approved these changes
Apr 7, 2024
mattsse
left a comment
Member
There was a problem hiding this comment.
I think this could be useful when used in manual serde impls
Member
|
i believe this is redundant code, as ruint uints support deserializing from number without any typewrapping or decoration serde helpers were not examined when porting from ethers so there have been a few redundant things 😅 |
Member
Member
|
on consideration, we might want to rename the helpers something like |
4 tasks
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution
Implement
is_zeromethod forU64HexOrNumber.PR Checklist