Skip to content

chore: remove redundant JsonU256 from ethers#443

Merged
prestwich merged 1 commit into
mainfrom
pretwich/remove-jsonu256
Apr 2, 2024
Merged

chore: remove redundant JsonU256 from ethers#443
prestwich merged 1 commit into
mainfrom
pretwich/remove-jsonu256

Conversation

@prestwich

Copy link
Copy Markdown
Member

Motivation

JsonU256 was never valuable in alloy, it was just copy/pasted

Solution

remove it

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the debt Tech debt which needs to be addressed label Apr 2, 2024
@prestwich prestwich self-assigned this Apr 2, 2024
@prestwich prestwich changed the title chore: remove redundant code from ethers chore: remove redundant JsonU256 from ethers Apr 2, 2024
@prestwich prestwich force-pushed the pretwich/remove-jsonu256 branch from 55f5b04 to 31f91bc Compare April 2, 2024 17:07

@mattsse mattsse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestwich prestwich merged commit bfd0fda into main Apr 2, 2024
@prestwich prestwich deleted the pretwich/remove-jsonu256 branch April 2, 2024 17:17
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Tech debt which needs to be addressed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants