Skip to content

fix: maybetagged serde for typed transaction#1495

Merged
onbjerg merged 1 commit intomainfrom
prestwich/maybe-tagged-typed-tx
Oct 19, 2024
Merged

fix: maybetagged serde for typed transaction#1495
onbjerg merged 1 commit intomainfrom
prestwich/maybe-tagged-typed-tx

Conversation

@prestwich
Copy link
Copy Markdown
Member

Motivation

closes #1494

Solution

Add MaybeTagged serde to TypedTransaction to allow deser of json objects missing the type flag

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich force-pushed the prestwich/maybe-tagged-typed-tx branch from b40eb5b to 72d46ef Compare October 17, 2024 12:45
@prestwich prestwich self-assigned this Oct 17, 2024
@prestwich
Copy link
Copy Markdown
Member Author

anyone? this is just a followup to #1489

Copy link
Copy Markdown
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@onbjerg onbjerg merged commit d910f4e into main Oct 19, 2024
@onbjerg onbjerg deleted the prestwich/maybe-tagged-typed-tx branch October 19, 2024 01:31
lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply MaybeTagged deser to TypedTransaction

2 participants