Adds the calling class to the string for the ajax hash to prevent collisions#794
Adds the calling class to the string for the ajax hash to prevent collisions#794
Conversation
dlh01
left a comment
There was a problem hiding this comment.
🌳 I wondered whether the post, term, and user datasources should get the same fix, since they override the default get_ajax_action(). But I see that each has a distinct leading string like fm_datasource_post and fm_datasource_term...except for the user datasource, which also uses fm_datasource_post (oops!). Can we switch that to fm_datasource_user while we're here? (Or drop the _type_ prefix from each and use get_called_class() like in the parent class.)
😆 |
|
@dlh01 I updated the other classes to all use |
|
@mslinnea Unfortunately, it seems that using I'm wondering whether the class name should be part of the hashed string instead, so maybe |
|
@dlh01 Valid point, I've updated these so that the called class is part of the hash, and I also fixed the preface for the user datasource. |
dlh01
left a comment
There was a problem hiding this comment.
🌳 Now we're cookin' with get_called_class()!
Addresses #621