Merged
Conversation
Member
There was a problem hiding this comment.
I'd like to know what that is a hash of. Hopefully something funny.
Contributor
Author
There was a problem hiding this comment.
It is something funny, but tbh I forgot what it is!
There was a problem hiding this comment.
Apparently it's "cucumber", or it least has a collision with it ;)
Contributor
Author
There was a problem hiding this comment.
👏 Hah, you're absolutely right! It's a part of the SearchPress trivia game; "cucumber" was the first search ever performed on a site using SearchPress.
Member
|
Other than the one note and despite you not remembering the origin of the hash, this receives a 🐴 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request completely refactors how search works. The overarching goal of the refactoring was to separate
SP_Searchinto more specific features. Search was initially tied to, and depended on, the main query.SP_Searchhandled this auto-integration, but then provided methods for using ES args or WP-style args for doing additional searches. While handy, these were bound to the main singleton, which didn't make much sense. This update separates these three distinct features into their own classes:SP_Search, which is the main class for performing a search with Elasticsearch, using the ES Query DSLSP_WP_Search, which extendsSP_Searchto add support for wp-style argumentsSP_Integration, which replaces core's search with SearchPress (and usesSP_WP_Searchto perform the query)