Skip to content

Fix Spellcheck#1779

Merged
mosteo merged 5 commits into
alire-project:masterfrom
Seb-MCaw:fix/spellcheck
Oct 14, 2024
Merged

Fix Spellcheck#1779
mosteo merged 5 commits into
alire-project:masterfrom
Seb-MCaw:fix/spellcheck

Conversation

@Seb-MCaw

@Seb-MCaw Seb-MCaw commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Closes #1776

The spellcheck check now has what I'm guessing is the intended behaviour:

Let me know if I have guessed incorrectly.

@Seb-MCaw Seb-MCaw force-pushed the fix/spellcheck branch 2 times, most recently from 0a60c2f to 7f12a3f Compare October 14, 2024 08:15
@Seb-MCaw Seb-MCaw marked this pull request as ready for review October 14, 2024 09:31
@mosteo

mosteo commented Oct 14, 2024

Copy link
Copy Markdown
Member

Your assessment is correct.

The pull_request_trigger considerations I think would be safe in this instance, but it doesn't seem important enough to open that can of worms.

@mosteo mosteo merged commit ad83bb5 into alire-project:master Oct 14, 2024
@Seb-MCaw Seb-MCaw deleted the fix/spellcheck branch October 14, 2024 10:57
mosteo pushed a commit that referenced this pull request Oct 21, 2024
* Add typos

* Fix spellcheck

* Revert "Add typos"

This reverts commit 282c3a7.

* Change docs without typo

* Revert "Change docs without typo"

This reverts commit 4d52934.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spellcheck does not fail when there are typos

2 participants