Add support for private indexes to "alr publish"#1745
Merged
mosteo merged 15 commits intoSep 24, 2024
Conversation
96a04a0 to
f98a0c4
Compare
f98a0c4 to
a67762c
Compare
mosteo
requested changes
Sep 20, 2024
mosteo
left a comment
Member
There was a problem hiding this comment.
Just minor things. Thanks for the comprehensive test!
Fabien-Chouteau
approved these changes
Sep 20, 2024
mosteo
approved these changes
Sep 24, 2024
Member
|
The publishing code is not one of the most straightforward in Alire, and the testing is particularly unfriendly, so congrats on this one. |
mosteo
pushed a commit
to mosteo/alire
that referenced
this pull request
Sep 27, 2024
…ex` (alire-project#1745) * Add support for private indexes to "alr publish" * Fix tests * Support "git@" remotes * Fix test * Bugfix * Update 'config' to 'settings' in 'alr init' * Update 'config' to 'settings' elsewhere * Rewrite documentation * Clarify upload instructions
Seb-MCaw
added a commit
to Seb-MCaw/alire
that referenced
this pull request
Jan 6, 2025
mosteo
added a commit
that referenced
this pull request
Jan 9, 2025
* Support command mocking on Windows * Add tests * Make archive download command configurable * Fix validation of distribution.override * Prevent configuring command settings locally * Remove redundant Download function * Add documentation * Self-review * Fix test on Windows when gunzip is only available from msys2 * Restructure documentation * Add erroneously omitted user-changes.md entry for #1745 * Update user-changes.md * Fix deprecated 'fail_on_error' in spellcheck workflow * Switch to US English spellings * Review --------- Co-authored-by: Alejandro R. Mosteo <amosteo@unizar.es>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1553
Currently, the
publishcommand always requires the user to provide (or have already configured) the username for a GitHub account, automatically forks the community index, and performs various other checks which are not necessarily applicable to private indexes. It also automatically raises a pull request into the community index, but this can be disabled with the--skip-submitswitch.This PR:
alr publish--skip-submitswitch to disable the requirement for a GitHub username to be provided and skip the automatic forking.--for-private-indexswitch, which disables those checks only applicable to the community index:alr initmaintainers-loginsfield optional (configuration ofuser.github_loginwas already optional).alr config.maintainers-loginsfield, or whosemaintainers-loginsfield has values which are invalid GitHub usernames (but empty strings are still considered invalid)