Fix monorepo bug wrt location of generated manifest#1684
Merged
Conversation
When deploying crates, to avoid confusion, we replace the packaged manifest (if any) with the one from the index, which is the one used anyway. For monorepos, the replacement was placed at the repo root instead of at the crate location.
dc3054c to
8369299
Compare
db668d4 to
11ca035
Compare
Fabien-Chouteau
approved these changes
May 29, 2024
mosteo
added a commit
that referenced
this pull request
May 30, 2024
* Fix monorepo bug wrt location of generated manifest When deploying crates, to avoid confusion, we replace the packaged manifest (if any) with the one from the index, which is the one used anyway. For monorepos, the replacement was placed at the repo root instead of at the crate location. * Use macOS 12 to avoid linking problems * Self-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying crates, to avoid confusion, we replace the packaged manifest (if any) with the one from the index, which is the one used anyway. For monorepos, the replacement was placed at the repo root instead of at the crate location.