Fix installation of binary crates containing softlinks#1653
Merged
Conversation
136d4e8 to
cf035eb
Compare
Fabien-Chouteau
approved these changes
Mar 20, 2024
mosteo
added a commit
that referenced
this pull request
Mar 20, 2024
* Force creation of missing soft link * More detailed test of softlink installation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a hard-to-reproduce bug related to the order of enumeration of files that manifested only when installing binary crates containing softlinks.
We saw this in the installation of gnat 10 in some workflows; the offending links do not seem to exist in later gnat packages.
This one and the other couple fixes we have I think merit the release of
2.0.1.