dev: control build jobs with $ALIRE_BUILD_JOBS#1651
Merged
Conversation
This is just a minor quality-of-life improvement for packaging. Note that this also quotes the argument to echo so that if (somehow) $ALIRE_OS were set to a malicious value, no harm could be done.
Contributor
Author
|
Am I correct to believe that this CI failure is unrelated? |
Member
Yes, those are unrelated, I'm on it. |
13 tasks
mosteo
approved these changes
Mar 18, 2024
mosteo
pushed a commit
that referenced
this pull request
Mar 20, 2024
This is just a minor quality-of-life improvement for packaging. Note that this also quotes the argument to echo so that if (somehow) $ALIRE_OS were set to a malicious value, no harm could be done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a minor quality-of-life improvement for packaging. Note that this also quotes the argument to echo so that if (somehow) $ALIRE_OS were set to a malicious value, no harm could be done.
By the way, congratulations on 2.0.0! Thanks so much :)