Tag builds done through alr build with unique build string#1530
Merged
Conversation
ac70f1c to
0290026
Compare
748ad18 to
cbdbbf2
Compare
Fabien-Chouteau
approved these changes
Feb 2, 2024
Member
Author
|
I will rewrite the python part in Ada to avoid having a hidden dependency on Python, so I'm leaving this unmerged for now. |
cbdbbf2 to
bcf67bb
Compare
cb95e2a to
3c07824
Compare
3c07824 to
c60bb9e
Compare
Fabien-Chouteau
approved these changes
Jun 13, 2024
mosteo
added a commit
that referenced
this pull request
Jun 23, 2024
* Replace version build with current commit hash * Detect dirtiness in . to flag it too in version * Fix for line terminators on Windows * Self-review * Ada version * Windows dispatcher script * Patch from the dev/build.sh script too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may help down the line with reports of people using development versions, to uniquely identify them.
A script is invoked before build to patch in the commit (and an extra flag if the working folder is dirty).
After the build, "_or_later" is added to the build string, so we have a lower bound, but we are not mislead by manual builds that don't trigger the patching (via pure
gprbuild).So, the new versions would look like
2.0-dev+abcd1234or2.0-dev+abcd1234_or_later.Since this triggers rebuilding a bunch of files if using
alr buildto build alr itself, it can be disabled by exportingALR_VERSION_DONT_PATCHin the environment to avoid those rebuilds during development.