Skip to content

Update msys2 installer#1284

Merged
mosteo merged 5 commits into
masterfrom
update-msys2-installer
Jan 12, 2023
Merged

Update msys2 installer#1284
mosteo merged 5 commits into
masterfrom
update-msys2-installer

Conversation

@Fabien-Chouteau

Copy link
Copy Markdown
Member

No description provided.

@Fabien-Chouteau

Copy link
Copy Markdown
Member Author

It's the pacman -Su command that is causing trouble. I don't know why yet and how to fix it.

Since there's also this problem with 1.2.1 we might have to publish a fix release.

@mosteo

mosteo commented Jan 10, 2023

Copy link
Copy Markdown
Member

This is vexing because IIRC I added that second update precisely to survive some other msys2 problems. Oh well.

@mosteo

mosteo commented Jan 12, 2023

Copy link
Copy Markdown
Member

I think I've got the solution. Push incoming.

@mosteo mosteo force-pushed the update-msys2-installer branch from f3a2c7c to 25b8ef6 Compare January 12, 2023 11:53
@mosteo

mosteo commented Jan 12, 2023

Copy link
Copy Markdown
Member

The remaining failure is because the self-build is done with the latest release, which doesn't contain the fix. So I think we're good to go.

@mosteo mosteo requested a review from a team January 12, 2023 12:37
@mosteo

mosteo commented Jan 12, 2023

Copy link
Copy Markdown
Member

@Fabien-Chouteau, for some reason I cannot add you directly as reviewer. If you can take a look at the PR, thanks!

@Fabien-Chouteau

Copy link
Copy Markdown
Member Author

Because I am the author of the PR. Also I can't approve the PR.

@mosteo

mosteo commented Jan 12, 2023

Copy link
Copy Markdown
Member

Oh right...

@mosteo mosteo merged commit 65eedaa into master Jan 12, 2023
@mosteo mosteo deleted the update-msys2-installer branch January 12, 2023 20:02
mosteo added a commit to mosteo/alire that referenced this pull request Jan 12, 2023
* Update msys2 installer

* Follow updated MSYS2 first install instructions

* Show proper error message if msys2 update fails

* Fix the command to query for pending updates

* Don't scare-warn needlessly during msys2 update

Co-authored-by: Alejandro R. Mosteo <amosteo@unizar.es>
mosteo added a commit that referenced this pull request Jan 12, 2023
* Update msys2 installer (#1284)

* Update msys2 installer

* Follow updated MSYS2 first install instructions

* Show proper error message if msys2 update fails

* Fix the command to query for pending updates

* Don't scare-warn needlessly during msys2 update

Co-authored-by: Alejandro R. Mosteo <amosteo@unizar.es>

* Bump version to 1.2.2

Co-authored-by: Fabien Chouteau <Fabien-Chouteau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants