workaround for gnatcoll-core#64 / gnatstudio#128#1141
Merged
Conversation
This is a workaround for issue AdaCore/gnatstudio#128 and AdaCore/gnatcoll-core#64 where GNAT Studio fails to open recently-updated or newly-created alire files. Breaking the Ada_Compiler_Switches up into two statements resloves this problem.
Member
|
As we use our own fork of gnatcoll for the moment this will come in handy. Thanks, @AJ-Ianozi. |
mosteo
approved these changes
Aug 18, 2022
mosteo
pushed a commit
that referenced
this pull request
Aug 18, 2022
This is a workaround for issue AdaCore/gnatstudio#128 and AdaCore/gnatcoll-core#64 where GNAT Studio fails to open recently-updated or newly-created alire files. Breaking the Ada_Compiler_Switches up into two statements resloves this problem.
Member
|
For the record, Alire is not reading gpr files at all. So Alire itself is not impacted by this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for issue AdaCore/gnatstudio#128 and AdaCore/gnatcoll-core#64 where GNAT Studio fails to open recently-updated or newly-created alire files.
The issue was fixed in AdaCore/gnatcoll-core@0553172 so if alire will be using that version of gnatcoll in their upcoming release, feel free to reject this PR. Otherwise, this does seem to fix the problem in a less drastic way than was suggested in gnatstudio#128 by breaking out the Ada_Compiler_Switches assignment into two statements. So
config/<crate>_config.gprfrom e.g.To e.g.
P.S. I am new to github, and this is my very first actual PR, so I apologize in advance if I did it incorrectly!