fix(generators): getObject has no generic type#6026
Merged
MarioAlexandruDan merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
- GenericPropagator: detect inline anonymous response schemas with x-is-generic and set x-return-is-generic on the operation so templates know T is the direct return type, not a wrapper type parameter - JS api-single.mustache: use x-return-is-generic to emit getObject<T = Record<string, unknown>>(): Promise<T> with a default type for backward compatibility - CTS generators: expose isReturnGeneric in test context for future use Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
742595b to
8bfcc7b
Compare
algolia-bot
added a commit
that referenced
this pull request
Mar 3, 2026
…kip ci] Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Mar 3, 2026
algolia/api-clients-automation#6026 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟 JIRA Ticket API-65:
Changes included:
🧪 Test