Skip to content

fix(specs): invalid API format for multi feed in Comp API#5993

Merged
Fluf22 merged 7 commits intomainfrom
clara/fix/comp-api-multifeed
Feb 18, 2026
Merged

fix(specs): invalid API format for multi feed in Comp API#5993
Fluf22 merged 7 commits intomainfrom
clara/fix/comp-api-multifeed

Conversation

@ClaraMuller
Copy link
Copy Markdown
Contributor

🧭 What and Why

Fix Invalid payload

🧪 Test

CI

@ClaraMuller ClaraMuller requested a review from a team as a code owner February 18, 2026 10:31
@algolia-bot
Copy link
Copy Markdown
Collaborator

algolia-bot commented Feb 18, 2026

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by fc341098fdb05755887e54a1aea5857157057460
🍃 Generated commit 321a52aac2c6d081b92f3e0318b80fd3d7f1fde2
🌲 Generated branch generated/clara/fix/comp-api-multifeed
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2322
go 2262
php 1843
csharp 1530
python 1354
java 1152
ruby 1044
swift 402
scala 23

@ClaraMuller ClaraMuller requested a review from a team as a code owner February 18, 2026 10:39
@ClaraMuller ClaraMuller force-pushed the clara/fix/comp-api-multifeed branch from ba6b6c6 to 941bbe7 Compare February 18, 2026 10:41
@ClaraMuller ClaraMuller changed the title fix(composition): invalid API format for multi feed fix(specs): invalid API format for multi feed Feb 18, 2026
@ClaraMuller ClaraMuller changed the title fix(specs): invalid API format for multi feed fix(specs): invalid API format for multi feed in Comp API Feb 18, 2026
@ClaraMuller ClaraMuller requested a review from e-krebs February 18, 2026 10:45
aiordache
aiordache previously approved these changes Feb 18, 2026
@ClaraMuller
Copy link
Copy Markdown
Contributor Author

@Fluf22 Do you have an idea why the Tests are not passing at all ?

@Fluf22
Copy link
Copy Markdown
Collaborator

Fluf22 commented Feb 18, 2026

Looks like the parser handling additionalProperties doesn't go deep enough in the tree
Let me take a look

@ClaraMuller ClaraMuller force-pushed the clara/fix/comp-api-multifeed branch from ec91925 to 071398d Compare February 18, 2026 14:18
@ClaraMuller
Copy link
Copy Markdown
Contributor Author

@Fluf22 @e-krebs @aiordache Normally this version should works

@ClaraMuller ClaraMuller requested a review from a team February 18, 2026 14:35
aiordache
aiordache previously approved these changes Feb 18, 2026
@Fluf22
Copy link
Copy Markdown
Collaborator

Fluf22 commented Feb 18, 2026

@ClaraMuller looks good! The breaking change comes from the change in multifeed but it's expected since the API was invalid, right?

@ClaraMuller
Copy link
Copy Markdown
Contributor Author

The breaking change comes from the change in multifeed but it's expected since the API was invalid, right?

Yes, and the feature is not yet enable for customers anyway.

Copy link
Copy Markdown
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@Fluf22 Fluf22 merged commit 9aafd69 into main Feb 18, 2026
36 checks passed
@Fluf22 Fluf22 deleted the clara/fix/comp-api-multifeed branch February 18, 2026 16:23
algolia-bot added a commit that referenced this pull request Feb 18, 2026
…nerated) [skip ci]

Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Feb 18, 2026
algolia/api-clients-automation#5993

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants