feat(specs): add optional feedID to composition result set#5991
Merged
ClaraMuller merged 1 commit intomainfrom Feb 18, 2026
Merged
feat(specs): add optional feedID to composition result set#5991ClaraMuller merged 1 commit intomainfrom
ClaraMuller merged 1 commit intomainfrom
Conversation
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
ClaraMuller
approved these changes
Feb 18, 2026
Contributor
ClaraMuller
left a comment
There was a problem hiding this comment.
genuine question
Do you know if there is a difference between having feedID directly described in resultsCompositionsResponse versus having au autonomous object (at client level generation side) ?
algolia-bot
added a commit
that referenced
this pull request
Feb 18, 2026
…enerated) [skip ci] Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Feb 18, 2026
algolia/api-clients-automation#5991 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
I was reading through the multifeed design document for documentation updates and realized I missed adding
feedIDto the result set when updating the clients. 🙈Changes included:
feedIDto thesearchResultsItemschema (currently only present when using themultifeedbehavior)🧪 Test
yarn cli generate javascriptgenerates a spec withfeedIDonresultsCompositionsResponse, which is used insearchResultsItem