fix(specs): add deprecated field condition in rule schemas#5983
fix(specs): add deprecated field condition in rule schemas#5983MarioAlexandruDan merged 20 commits intomainfrom
condition in rule schemas#5983Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
@raed667 I was wandering if rule |
…backward compatibility
specs/composition/common/schemas/components/CompositionRule.yml
Outdated
Show resolved
Hide resolved
|
@MarioAlexandruDan thanks for the headsup ! Indeed the recommend rules API seems to accept We'll need to adapt the dashboard rules editor to support both. |
|
@raed667 should we wait for your go before releasing the change? |
|
I think it is OK/safe to add As for exposing 1- should we support an array but only take the first item ? 2- should we update the Recommend rules dashboard to allow for multiple conditions ? |
|
@Fluf22 I created a ticket to handle the Recommend rules dashboard. https://algolia.atlassian.net/browse/PRED-4467 I suggest stashing the changes to |
|
Thanks @raed667 ! We will do that, and wait for the ticket to be done to put that back |
…(generated) [skip ci] Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia/api-clients-automation#5983 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
🧭 What and Why
🎟 JIRA Ticket API-286:
Changes included:
🧪 Test