Skip to content

fix(specs): add deprecated field condition in rule schemas#5983

Merged
MarioAlexandruDan merged 20 commits intomainfrom
fix/specs-rule-condition
Feb 25, 2026
Merged

fix(specs): add deprecated field condition in rule schemas#5983
MarioAlexandruDan merged 20 commits intomainfrom
fix/specs-rule-condition

Conversation

@MarioAlexandruDan
Copy link
Copy Markdown
Contributor

@MarioAlexandruDan MarioAlexandruDan commented Feb 16, 2026

🧭 What and Why

🎟 JIRA Ticket API-286:

Changes included:

  • List changes

🧪 Test

@algolia-bot
Copy link
Copy Markdown
Collaborator

algolia-bot commented Feb 16, 2026

✔️ Code generated!

Name Link
🪓 Triggered by 468dd38cb2ed9fbfcb77cc1d9d9e57e03258f602
🍃 Generated commit 3bd646de5ccf9cd1bc5c728163c49fcf44c1f160
🌲 Generated branch generated/fix/specs-rule-condition
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2560
php 2195
go 2185
csharp 1610
python 1377
java 1155
ruby 1068
swift 615
scala 23

@MarioAlexandruDan
Copy link
Copy Markdown
Contributor Author

@raed667 I was wandering if rule condition/conditions will affect Recommend. Can you please advise here ?

@MarioAlexandruDan MarioAlexandruDan marked this pull request as ready for review February 17, 2026 12:36
@MarioAlexandruDan MarioAlexandruDan requested a review from a team as a code owner February 17, 2026 12:36
@raed667
Copy link
Copy Markdown
Contributor

raed667 commented Feb 17, 2026

@MarioAlexandruDan thanks for the headsup ! Indeed the recommend rules API seems to accept conditions but the dashboard silently breaks.

https://dashboard.algolia.com/apps/F4T6CUV2AH/recommend/rules/pokedex/related-products/edit?ruleID=rr-1767888945553

We'll need to adapt the dashboard rules editor to support both.

@Fluf22
Copy link
Copy Markdown
Collaborator

Fluf22 commented Feb 18, 2026

@raed667 should we wait for your go before releasing the change?

@raed667
Copy link
Copy Markdown
Contributor

raed667 commented Feb 19, 2026

I think it is OK/safe to add condition and mark it as deprecated 👍

As for exposing conditions for Recommend rules, let me check the expected dashboard behavior:

1- should we support an array but only take the first item ?

2- should we update the Recommend rules dashboard to allow for multiple conditions ?

@raed667
Copy link
Copy Markdown
Contributor

raed667 commented Feb 20, 2026

@Fluf22 I created a ticket to handle the Recommend rules dashboard.

https://algolia.atlassian.net/browse/PRED-4467

I suggest stashing the changes to specs/recommend/common/schemas/RecommendRule.yml until this ticket is done.

@Fluf22
Copy link
Copy Markdown
Collaborator

Fluf22 commented Feb 20, 2026

Thanks @raed667 ! We will do that, and wait for the ticket to be done to put that back

Copy link
Copy Markdown
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@MarioAlexandruDan MarioAlexandruDan enabled auto-merge (squash) February 25, 2026 09:40
@MarioAlexandruDan MarioAlexandruDan merged commit 505136c into main Feb 25, 2026
36 checks passed
@MarioAlexandruDan MarioAlexandruDan deleted the fix/specs-rule-condition branch February 25, 2026 09:48
algolia-bot added a commit that referenced this pull request Feb 25, 2026
…(generated) [skip ci]

Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Feb 25, 2026
algolia/api-clients-automation#5983

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants