fix(specs): add missing redirect property to rule consequence schema#5934
Merged
fix(specs): add missing redirect property to rule consequence schema#5934
redirect property to rule consequence schema#5934Conversation
The `consequence` object in the Search API rules spec was missing the `redirect` property, which is used by "Redirect to Virtual Replica" rules. This caused all generated API clients to silently drop the redirect data during deserialization, producing empty consequences when round-tripping rules via SearchRules + SaveRules. CR-10356
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
Thanks for drafting this up! But I'm confused given this feature has been working in beta for years. Was this property always missing here? How was this working before? |
drodriguln
reviewed
Feb 6, 2026
| $ref: '../../../../common/parameters.yml#/objectID' | ||
| required: | ||
| - objectID | ||
| redirect: |
There was a problem hiding this comment.
lgtm. Something tells me you found the docs then.
Collaborator
Author
There was a problem hiding this comment.
I inferred what I put in the update from the API response 😁
But I wanted validation because I wasn't sure if other params were required or not
Thanks for the doc link anyway, I'll merge this PR!
Collaborator
Author
The |
eric-zaharia
approved these changes
Feb 10, 2026
drodriguln
approved these changes
Feb 10, 2026
algolia-bot
added a commit
that referenced
this pull request
Feb 11, 2026
#5934) (generated) [skip ci] Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Feb 11, 2026
…a (generated) algolia/api-clients-automation#5934 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The
consequenceobject in the Search API rules spec was missing theredirectproperty, which is used by "Redirect to Virtual Replica" rules. This caused all generated API clients to silently drop the redirect data during deserialization, producing empty consequences when round-tripping rules via SearchRules + SaveRules.🎟 JIRA Ticket: CR-10356
Changes included: